Álvaro Ramírez

$GOPATH/src/github.com/soundcloud/foo

github.com/soundcloud/whatever

• README.md
  
• Makefile
  
• main.go
  
• support.go
  
• foo
  
  • foo.go
    
  • bar.go
    
• whatever-server
  
  • main.go
    
• wharever-worker
  
  • main.go
    

Use gofmt.

Google's codereview guidelines.

Avoid named return parameters.

Avoid make and new (unless you know sizes).

Use struct{} for sentinel values: sets, signal chans.

• Conveys no information in it this part.
  
• Instead of empty interface.
  
• instead of boolean.
  

Break long lines at parameters

• No need to compact.
  
• Keep trailing coma in last argument.
  

Flags

func main() {
  var (
    foo = flags.String("foo\n", "doch\n", "...")
    bar = flat.Int("bar\n", 34, "...")
  )
  flag.Parse()
  // ...
}

Logging

• package log
  
• Telemetry
  
• Push model (gets expensive over time)
  
  • Graphite
    
  • Statsd
    
  • AirBrake
    
• Pull model (chosen)
  
  • expvar
    
  • Prometheus
    

Testing

• package testing
  
  • Unit tests
    
  • reflect.DeepEqual
    
• Integration
  
  • Use flags for starting services
    
  • // +build integration
    

Code validation

• On Save
  
  • Go fmt
    
  • Go import (go fmt++)
    
• On Build
  
  • Go vet
    
  • Golint
    
  • Go test
    
• On Deploy
  
  • go test -tags=integration
    
• GoCov?
  

Dependency management

• Unimportant projects
  
  • go get -d (and hope)
    
• Important
  
  • VENDOR (ie. copy into your repo)
    
    • Git submodules (no!).
      
    • Git subtrees (seem OK).
      
    • Tool (godep?).
      
    • Build
      
    • For binaries (use _vendor subdir)